wschreyer / PENTrack

PENTrack - a simulation tool for ultra-cold neutrons, protons and electrons
GNU General Public License v2.0
8 stars 20 forks source link

Reducing number of BFIntegrator object pointers instatiated #39

Closed ssc5 closed 8 years ago

ssc5 commented 8 years ago

Explanations:

Before commit 75521d0, in the case of simultaneous spin integration, the BFint1 and BFint2 in particle.cpp should pass different E fields (one is the negative of the other) to the BFIntegrator::Integrate. Before this they were both passing E1down or E2down. Also different B fields should be passed by BFint1 and BFint2 because the BFIntegrator::Integrate function changes the values of B1 and B2 that are passed to it.

With commit 174030b I think the spinlog output should finally work in all cases.

Also what is your thinking regarding issue #37? I think it would be valuable to have E and velocity components at least for the short term because they would've easily identified the bug corrected by commit 75521d0.