wschwanghart / topotoolbox

A MATLAB software for the analysis of digital elevation models -
https://topotoolbox.wordpress.com/
153 stars 89 forks source link

mistake in curvature function #2

Closed chinasio closed 8 years ago

chinasio commented 8 years ago

switch ctype case 'profc' curv = - (p.^2 .* r + 2_p._q._s + q.^2.t)./((p.^2 + q.^2).(1 + p.^2 + q.^2).^(3)); case 'tangc' curv = - (q.^2 ._ r + 2_p._q._s + p.^2.t)./((p.^2 + q.^2).(1 + p.^2 + q.^2).^(3)); case 'planc' curv = - (q.^2 ._ r + 2_p._q._s + p.^2._t)./((1 + p.^2 + q.^2).^(3)); case 'meanc' curv = (p.^2 .* r + 2_p._q._s + q.^2.t)./((p.^2 + q.^2).(1 + p.^2 + q.^2)) ...

end the tanc and profc is the same formula,

wschwanghart commented 8 years ago

In fact, profc and tangc did not have the same formula, but they were wrong nevertheless. The new curvature function now adopts the formulas used in Schmidt et al. (2003, p. 800). Note, however, that the planform or contour curvature equation has an error in that publication. The first term should start with fxx fy.^2.

Schmidt, J., Evans, I.S., Brinkmann, J., 2003. Comparison of polynomial models for land surface curvature calculation. International Journal of Geographical Information Science 17, 797–814. doi:10.1080/13658810310001596058