search

wscott / fplan

Early retirement financial calculator
GNU General Public License v3.0
26 stars 6 forks source link

standardize on using percentages not decimals #22

Closed hubcity closed 5 months ago

hubcity commented 5 months ago

Once you merge the state taxes pull request I will probably need to revisit this one.

The switch to tomllib is in case the users put in something like [[0, 10.0]]

With python <3.11 and toml this throws a heterogeneous type error, but with tomllib it works. I based this change on https://github.com/jendrikseipp/vulture/issues/339

hubcity commented 5 months ago

Something about this is broken, but I don't know what.

wscott commented 5 months ago

I assume that using 0.0 would fix it?

On Thu, Jan 25, 2024 at 3:26 PM hubcity @.***> wrote:

Something about this is broken, but I don't know what.

— Reply to this email directly, view it on GitHub https://github.com/wscott/fplan/pull/22#issuecomment-1910947085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHV73DY65RCZSFRAMQUD3YQK5YZAVCNFSM6AAAAABCLB7HM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQHE2DOMBYGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hubcity commented 5 months ago

I moved the decimal vs whole number fix to a different PR. All the tax numbers in the PR are whole numbers and calculating correctly, I think.

wscott commented 5 months ago

I did a quick merge, but clearly, these config values need to be under the same [taxes] section as well now. Also, how about getting rid of the sample_taxrates file and include the 'single' table as a comment in the example file.