wsdjeg / dein-ui.vim

UI for Shougo's dein.vim
GNU General Public License v3.0
162 stars 12 forks source link

Suggestion #1

Closed Shougo closed 6 years ago

Shougo commented 6 years ago
wsdjeg commented 6 years ago

@Shougo I am sorry, This plugin is automatically detached from SpaceVim via travis, so all files are same as SpaceVim, except:

you can see the detach script. https://github.com/SpaceVim/SpaceVim/blob/master/.ci/detach_plugin.sh#L40-L62

In order to automatically synchronize from upstream, we need to keep the file consistent.

wsdjeg commented 6 years ago

DeinUIUpdate or DeinUpdate is better than SPUpdate.

we can add this command in plugin/deinui.vim

Shougo commented 6 years ago

In order to automatically synchronize from upstream, we need to keep the file consistent.

Oh...

wsdjeg commented 6 years ago

when I update this script in SpaceVim, I hope this repo can be updated automatically.

weilbith commented 6 years ago

@Shougo this plugin also requires to set the SpaceVim variable g:spacevim_plugin_manager, what's kinda ugly, if not using SpaceVim, to define the plugin manager to call its update function. Couldn't this be set to a default value that points to dein.vim?

weilbith commented 6 years ago

g:spacevim_plugin_manager_max_processes is also required. Afterwards I get the following error:

E475: Invalid argument: expecting valid directory

Too bad, that it is not usable without SpaceVim liked the realtime feedback...

wsdjeg commented 6 years ago

Ok, This repo is still WIP, I should add this to README

wsdjeg commented 6 years ago

I have updated the description

Shougo commented 6 years ago

Couldn't this be set to a default value that points to dein.vim?

It cannot. It should be fixed in dein-ui.vim plugin.

weilbith commented 6 years ago

@Shougo correct. I took a look into the code, but it doesn't look like it could be speparated from all the SpaceVim staff that ez...

wsdjeg commented 6 years ago

I have added DeinUpdate command, and fix the spacevim options, It should works now.