Coin total incorrect when multiple banks played

wshuaierick / androminion

Automatically exported from code.google.com/p/androminion

0 stars 0 forks source link

What steps will reproduce the problem?
1.  Play a Prosperity game with Banks.  Buy as many banks as possible.
2.  Bank total is not calculated correctly.  A hand with Gold, Silver, Bank, 
Bank, Bank should be 3+2+5+5+5 = 20.  Game calculates 17.  A hand with Copper 
Copper Bank Bank Estate should be 1+1+4+4 = 10.  Game calculates 9.  Silver 
Bank Bank should be 2 + 3 + 3 = 8.  Game calculates 7.  Bank Bank Bank Bank 
should be 4+4+4+4 = 16.  Game calculates 10.

What is the expected output? What do you see instead?
Banks should be calculated once all treasures have been played, not calculated 
at the point each bank was played.  In the 4 bank example, I believe it plays 
Bank 1 for 1, Bank 2 for 2, Bank 3 for 3, and Bank 4 for 4. 1+2+3+4 = 10.

What version of the product are you using? On what operating system?
Androminion 2.3 on Android 4.0.

Please provide any additional information below.

Original issue reported on code.google.com by chawa...@gmail.com on 4 Apr 2012 at 9:27

The current implementation of Bank is correct. Treasures are played one at a time. From the Prosperity rulebook: "Bank - This is a Treasure worth a variable amount. When you play Bank, it is worth (1) per Treasure you have in play, counting itself. Remember, you choose what order to play Treasure cards. If you play Bank with no other Treasures in play, it is worth (1). If you play two copies of Bank in a row, the one you play second will be worth (1) more than the first one. Bank produces money right when you play it; things that happen later in the turn will not change how much money you got from it." The rulebook also has a Bank example in the sample turn.

wshuaierick / androminion

Coin total incorrect when multiple banks played #325