search

wshuaierick / androminion

Automatically exported from code.google.com/p/androminion
0 stars 0 forks source link

Mine a Copper with no Silver left and you get nothing #334

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Play a game until there is no Silver or Gold or Platinum left. This empty 
pile will be referred to as the empty pile.
2. Play a Mine from your hand and trash a treasure card from your hand that 
costs 3 less than the treasure that was in the empty pile
3. Select the empty pile.
4. Receive nothing

What is the expected output? What do you see instead?
The expected output is that you should not be able to select the empty pile as 
there are no cards left. You should still be able to trash a copper if there is 
no silver and gain a copper but you should not be able to select the silver at 
all.

What version of the product are you using? On what operating system?
Latest on Android

Please provide any additional information below.
I'd like to help fix this problem :D

Original issue reported on code.google.com by makosbl...@gmail.com on 9 Apr 2012 at 10:12

GoogleCodeExporter commented 9 years ago 
Android 2.3.3*

Original comment by makosbl...@gmail.com on 9 Apr 2012 at 11:18

GoogleCodeExporter commented 9 years ago 
I'm pretty sure this can be remedied by adding a check to make sure the pile 
that newCard is a part of is not empty around line 860 in 
com.vdom.core.ActionCardImpl.java.

Original comment by makosbl...@gmail.com on 10 Apr 2012 at 12:17

GoogleCodeExporter commented 9 years ago 
Issue 275 describes a similar situation with Swindler.

Most of the time when a card asks a player to do something that would require 
them to choose a card, a player should not be able to choose an empty pile.  
The only exception I can think of is Wishing Well (and, technically, 
Contraband).

Original comment by August.D...@gmail.com on 10 Apr 2012 at 1:46

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r559.

Original comment by tkdenni...@gmail.com on 29 Jul 2012 at 7:49

GoogleCodeExporter commented 9 years ago 
The BasePlayer AI limits treasure selected to ones that can be mined. I 
modified the BasePlayer to return the lowest-valued treasure if a mineable card 
is not found, and ActionCardImpl to select a random treasure card from hand if 
one exists but none selected so no player can skip the card to trash. 
ActionCardImpl will also look for a valid treasure card from the table so that 
can't be skipped either.

Original comment by tkden...@gmail.com on 29 Jul 2012 at 7:51

GoogleCodeExporter commented 9 years ago 
It looks like a UI issue to stop empty piles from being selectable - maybe add 
parameter to getTreasureFromTable or SelectCardOptions to disallow empty pile 
when selecting from Table?

Original comment by tkdenni...@gmail.com on 29 Jul 2012 at 7:54

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r651.

Original comment by mooht...@gmail.com on 5 Sep 2012 at 12:13