search

wsloth / Index

The Index is a simple Hacker News reader app which is focused on making you read less, by only showing you the top stories of the last 24 hours.
10 stars 9 forks source link

Implemented Onboarding Screen. #12

Closed ShivamMenda closed 2 years ago

ShivamMenda commented 2 years ago

Added Onboarding screen with graphics.

wsloth commented 2 years ago

Thanks for your contribution @ShivamMenda! I'm currently not able to review the changes in the app because I don't have my right computer with me, but I will check it out later tonight. In any case, this PR is definitely hacktoberfest-accepted! 👏

I'll keep you updated on the merge progress.

ShivamMenda commented 2 years ago

@wsloth Thank you. I have to mention that this is really well built app. Keep me updated with the merge process by tagging me.

ShivamMenda commented 2 years ago

@wsloth Thank you for your feedback. There is a package called share preferences to store the Device state of the user. I'll check it out. I'm not sure about this part but I'll check it out and let you know. I have never worked with share preferences.

ShivamMenda commented 2 years ago

@wsloth I'll let you know what I can do about the state and storing the flag after researching.

wsloth commented 2 years ago

Thanks for taking a look @ShivamMenda! And let me know if you're unable to figure it out, in which case I'll create a separate issue request for it :)

ShivamMenda commented 2 years ago

@wsloth yeah I'll keep you updated. Is it fine if I take a day to research and get back to you?

wsloth commented 2 years ago

@ShivamMenda that's totally fine. Take all the time you need

ShivamMenda commented 2 years ago

@wsloth Sure will get back to you.Thanks.

ShivamMenda commented 2 years ago

@wsloth I wasn't able to find a way to implement the flag for storing the state. I haven't worked with shared preferences before and it's a bit confusing. I'm sorry.

ShivamMenda commented 2 years ago

@wsloth any update on the merge?

wsloth commented 2 years ago

Sorry, I've been busy the last couple of days! Accepting the merge as-is, and I'm creating a new issue for somebody to pick up to store the introduction screen shown state in device storage.

ShivamMenda commented 2 years ago

Okay @wsloth no problem. Thank you.