wslutilities / wslu

A collection of utilities for Windows Subsystem for Linux
https://wslutiliti.es/wslu
GNU General Public License v3.0
3.44k stars 155 forks source link

fix: [#268] do not validate URL when skip flag is used #301

Closed JaZo closed 7 months ago

JaZo commented 9 months ago

Description

I stumbled upon #268 and saw you added the -s, --skip-validation-check flag. I checked the fix, but if I interpret the code correctly, it still does validate the URL, but now it just ignores the result. This does not fix the issue with one-time URL's described in https://github.com/wslutilities/wslu/issues/268#issuecomment-1476208820. The name of the flag also suggests it completely skips the check instead of ignoring the result, so that's what I changed it into.

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected) are no longer accepted

Checklist: