search

wslyvh / proof-of-competence

Proof of Competence (PoC) is an open, modular framework to create on-chain quests and Web3 on-boarding journeys.
https://www.poc.quest/
MIT License
72 stars 19 forks source link

check amount using ?. operator #7

Closed fjun99 closed 2 years ago

fjun99 commented 2 years ago

small modification to make the code better

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @wslyvh on Vercel.

@wslyvh first needs to authorize it.

fjun99 commented 2 years ago

please refuse this pull request. sorry.

fjun99 commented 2 years ago

sorry for bother. revert my changes.

a note: if you can rm yarn.lock from git tracking, i think it will make the workflow better as yarn.lock changes a lot.

wslyvh commented 2 years ago

The yarn.lock file should be part of the solution actually. It ensures installations across environments remain consistent. I did an upgrade of all packages this weekend, but usually this shouldn't change that much and be too much of an issue.

wslyvh commented 2 years ago

And no worries about the PR. I guess it makes sense to update/refactor some parts. I don't have a strong opinion, as long as it's consistent across the solution