AnimatedSprite review

[GoogleCodeExporter]

Purpose of code changes on this branch:
The animated Sprite has been recoded to be simpler and avoid segmentation 
faults.

When reviewing my code changes, please focus on:
Can it be more simple? Did i avoid all the segmentation faults?

the review concerns the following revisions :

http://code.google.com/p/emp-impulse/source/detail?r=467f6ca1dc90e1011e52bc5df70
723893a0d8967&repo=dev-scene

Original issue reported on code.google.com by chino...@gmail.com on 31 Oct 2010 at 4:07

[GoogleCodeExporter]

Original comment by chino...@gmail.com on 31 Oct 2010 at 4:09

[GoogleCodeExporter]

The implementation is now much more stable (I could not get it to crash or leak 
memory), which is a very good thing :D

Nevertheless, IMO, the implementation is still too complex for what you are 
doing (I commented the code). I would highly recommend you look at the 
ParticleEmitter and Background classes, which do the same thing you are doing 
with images in simpler ways. The same loading logic can also be applied to 
animation data.

Original comment by remi.papillie@gmail.com on 31 Oct 2010 at 4:45

[GoogleCodeExporter]

- Changed issue name -

Original comment by remi.papillie@gmail.com on 31 Oct 2010 at 4:46

• Changed title: AnimatedSprite review

[GoogleCodeExporter]

Original comment by bloutiouf on 31 Oct 2010 at 4:50

• Changed state: Accepted

[GoogleCodeExporter]

The repo has been renamed, please consider this url now.

http://code.google.com/p/emp-impulse/source/detail?r=467f6ca1dc90e1011e52bc5df70
723893a0d8967&repo=dev

Original comment by bloutiouf on 6 Apr 2011 at 9:28

[GoogleCodeExporter]

I am rescueing dead issues. Maybe this one will be reassigned to someone else 
later.

Original comment by remi.papillie@gmail.com on 6 Apr 2011 at 10:52

• Added labels: Priority-Low
• Removed labels: Priority-Medium