search

wsmind / emp-impulse

Automatically exported from code.google.com/p/emp-impulse
0 stars 0 forks source link

Particle emitter review request #8

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The particle emitter (in the scene module) is an abstraction for the particle 
system (in the engine module). It aims at providing a cool interface to the 
game, also abstracting the resource management.

The review focuses on the first implementation of the particle emitter. It uses 
two resources: a particle descriptor and an image. For now, the descriptor is 
hardcoded, since it will be a substantial dev.

The review concerns the following revisions (newest to oldest):
http://code.google.com/p/emp-impulse/source/detail?r=f096801121ea15d432fdc0e688d
c25ac19f6d17f&repo=dev-scene
http://code.google.com/p/emp-impulse/source/detail?spec=svn.dev-scene.f096801121
ea15d432fdc0e688dc25ac19f6d17f&repo=dev-scene&r=f6e558097625fce4f6783c854ce28db4
3244ffd7
http://code.google.com/p/emp-impulse/source/detail?spec=svn.dev-scene.f096801121
ea15d432fdc0e688dc25ac19f6d17f&repo=dev-scene&r=251b9df7eca57badd6006a6a20b5dff0
5fa73677

Note: I am trying a new method for the review with the above links. If all 
works fine, comments should be set only in the newest revision. Otherwise, pray 
:)

Original issue reported on code.google.com by bloutiouf on 21 Oct 2010 at 6:48

GoogleCodeExporter commented 9 years ago 
I made a first pass of comments ;)

Original comment by remi.papillie@gmail.com on 23 Oct 2010 at 5:29

GoogleCodeExporter commented 9 years ago 
Corrected :)

New revision:
http://code.google.com/p/emp-impulse/source/detail?spec=svn.dev-scene.f096801121
ea15d432fdc0e688dc25ac19f6d17f&repo=dev-scene&r=71c9f0972d67f43f8d6ff13c8f4c7166
6e300844

Original comment by bloutiouf on 23 Oct 2010 at 8:07

GoogleCodeExporter commented 9 years ago

Original comment by chino...@gmail.com on 23 Oct 2010 at 10:49

GoogleCodeExporter commented 9 years ago 
Oops I didn't look at the right log.

However this revision introduces a new *big* bug, when the requested particle 
image does not exist.

New revision:
http://code.google.com/p/emp-impulse/source/detail?spec=svn.dev-scene.f096801121
ea15d432fdc0e688dc25ac19f6d17f&repo=dev-scene&r=b7141afe8c59236eacdb1648fb759afc
fddabad8

Original comment by bloutiouf on 23 Oct 2010 at 11:56

GoogleCodeExporter commented 9 years ago 
Hehe great that you changed this points to arrows :p

Original comment by remi.papillie@gmail.com on 23 Oct 2010 at 1:57

GoogleCodeExporter commented 9 years ago 
I know, it's a shame :D
I discuss with Davy to settle the bug.

Original comment by bloutiouf on 23 Oct 2010 at 2:00

GoogleCodeExporter commented 9 years ago 
I am rescueing dead issues. Maybe this one will be reassigned to someone else 
later.

Original comment by remi.papillie@gmail.com on 6 Apr 2011 at 10:52