search

wsmoses / Tapir-LLVM

Tapir extension to LLVM for optimizing Parallel Programs
Other
132 stars 24 forks source link

Two minor fixes #11

Closed VictorYing closed 7 years ago

VictorYing commented 7 years ago

One fix to a function name mentioned in a comment.

Other fix properly removes traces of the /tools/clang/ submodule. Prior to this patch, the current state of the git index on "master" of wsmoses/Parallel-IR still remembers that there is a directory /tools/clang/ which was a submodule, which may cause confusion among 6.S898 class members who are unfamiliar with git submodules when they try to look at git status reports, or do a local "git add --all" or "git commit -a" after making some changes to clang.

VictorYing commented 7 years ago

@wsmoses @neboat Is it bad juju that these two fixes are unrelated and in the same pull request? I'm not very familiar with GitHub pull requests, and it wasn't obvious how to separate them without messing with git history in my fork, but with such small changes I think you can sort it out to your satisfaction on your end.

wsmoses commented 7 years ago

The way you did it was fine. Ideally they'd be separate but these are so small it doesn't matter