search

wsmoses / Tapir-LLVM

Tapir extension to LLVM for optimizing Parallel Programs
Other
133 stars 24 forks source link

C and OCaml bindings for Tapir #66

Closed Willtor closed 6 years ago

Willtor commented 6 years ago

When you wish upon a star, makes no difference who you are. Because in space, no one can hear you scream.

neboat commented 6 years ago

I'm excited to see these additions. The changes looks good to me. Do you have a test case handy for verifying that these changes work?

Willtor commented 6 years ago

I don't have anything small that tests them. DEF will use these changes as soon as they're ready. I can commit and push those changes, though I was planning on doing it in the opposite order. Is that what we need?

Willtor commented 6 years ago

Okay! I've created a tapir-transition branch to DEF: https://github.com/Willtor/def/tree/tapir-transition And I added the c28866e changeset that works with that branch (and fixes a missing macro bug).

wsmoses commented 6 years ago

Sorry, apparently CI wasn't configured properly for PR's from external forks, if you don't mind repushing to trigger a build (and then you'll be able to merge once the build passes).

Willtor commented 6 years ago

I'll add the OCaml stuff into the unit tests for it. That'll cover the C bindings, too, since OCaml uses them. When I push that change, will that trigger the build?

Willtor commented 6 years ago

Like a boss!