wso2-extensions / identity-inbound-provisioning-scim2

Apache License 2.0
8 stars 152 forks source link

Fix lack of exception when attempting to update a non-existent role name #537

Closed AmshikaH closed 8 months ago

AmshikaH commented 8 months ago

Purpose

Previously, when addressing https://github.com/wso2/product-is/issues/14095, the updateRoleName method's was changed to print a warn log instead of throwing an exception via https://github.com/wso2-extensions/identity-inbound-provisioning-scim2/pull/435, which was a temporary fix which had not been reverted even after a proper fix was added.

This PR reverts the temporary fix and allows an exception to be thrown instead of a warn log.

With this change, the SOAP API will be able to identify the failure of the operation and return the status as 500 Internal Server Error along with the error message.

Related PRs

Related Issues

jenkins-is-staging commented 8 months ago

PR builder started Link: https://github.com/wso2/product-is/actions/runs/8182128692

jenkins-is-staging commented 8 months ago

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/8182128692 Status: success