search

wso2-extensions / identity-outbound-auth-x509

Apache License 2.0
1 stars 55 forks source link

Change private method to protected #39

Closed tharakawijekoon closed 4 years ago

tharakawijekoon commented 4 years ago

Change the private method to protected so that classes that extend the X509CertificateAuthenticator can use the same method.

tharindu-b-hewage commented 4 years ago

Hi @tharakawijekoon,

Could you please kindly explain more about the insights behind this design change, and what benefits would it bring to the authenticator implementation?

tharakawijekoon commented 4 years ago

Hi @tharindu-bandara,

I believe a derived class could benefit from using the method, making the method protected would allow it to do so, while making it private would deny it that benefit.

Yes, Keeping the method private would allow that future version to change the behavior (or eliminate the method entirely), while making it protected would require all future versions of the class to keep the same behavior, thus denying the benefit that could be reaped from changing it.

We have a realistic scenario here[1] where a derived class will benefit from being able to access the method.

[1]https://github.com/tharakawijekoon/CustomX509CertificateAuthenticator

piraveena commented 4 years ago

Sends this fix to 2.0.x branch with this PR https://github.com/wso2-extensions/identity-outbound-auth-x509/pull/42. Hence closing this PR