wso2 / api-manager

All issues, tasks, improvements and new features of WSO2 API Manager
Apache License 2.0
34 stars 8 forks source link

Fix SMB2 test failures on public & 4.1.0 jenkin jobs #1449

Closed dulithsenanayake closed 1 year ago

dulithsenanayake commented 1 year ago

Description

The following SMB2 test cases are failing in the master & 4.1.0 branches. Need to fix them.

Steps to Reproduce

Run SMB2 tests on jenkins.

Affected Component

MI

Version

4.2.0

Environment Details (with versions)

No response

Relevant Log Output

No response

Related Issues

No response

Suggested Labels

No response

malakaganga commented 1 year ago

Update: I have analyzed all the codes we have ported to fix smb2 issues but seems the porting is done fine. But in 4.1.0 n master 2 tests related to resuming after ConnectionFailure (partial) are failing. But in 6.6.0 the same tests are passing. So now I am creating a local setup and trying to mimic the behavior since it'll be easy to mimic and debug.

Helped with swiss grid FTP ideal connection issue.

Thanks, Malaka

malakaganga commented 1 year ago

Update: These are concurrent, full connection, and partial connection close tests so bit hard to debug. Locally tested and running the test suite after a possible fix will update the master branch when tests are getting passed.

Thanks, Malaka

malakaganga commented 1 year ago

On leave today due to a doctor's appointment.

malakaganga commented 1 year ago

Update: Master build was success: https://wso2.org/jenkins/job/products/job/micro-integrator/1869/

Screenshot from 2023-02-20 06-55-40

Waiting for 4.1.0.x-full build when its success will close the issue

malakaganga commented 1 year ago

Update: the wso2mi-4.1.0.x-full build was a Screenshot from 2023-02-20 19-21-12 success as well.

Hence closing the issue