search

wso2 / balana

Apache License 2.0
122 stars 108 forks source link

Removed override of returnsBag in GeneralBagFunction. #145

Closed mdrozdo closed 3 years ago

mdrozdo commented 4 years ago

Purpose

Resolves issue https://github.com/wso2/balana/issues/144

I removed the override of the returnsBag function so that the code uses the field from the base class. I didn't find any issues with this in Balana tests nor in tests for my project using it.

tharindu-b-hewage commented 4 years ago

@mdrozdo Could you please explain more on the requirement/issue behind this change? Usually, we do not change public APIs in the code...

mdrozdo commented 4 years ago

The issue occurs when using a bag function for a custom attribute data type, e.g. the Geometry data type in: https://github.com/TU-Berlin-SNET/tresor-pdp/blob/786e75f2801901ffdb21a662514069fec0a6b741/modules/geoxacml/src/main/java/org/geotools/xacml/geoxacml/config/GeoXACML.java#L187

(See also my description of https://github.com/wso2/balana/issues/144)

The code worked fine prior to https://github.com/wso2/balana/commit/647338610fc689d799af0f3d4e8222947ef42155.

The API doesn't really change as this PR only removes the override of the method defined in the base class. I haven't noticed any issues when using the base implementation.

What was the reason for introducing this override?