Add the V3 compare functions to the Target Function list

jimsch commented 4 years ago

Purpose

Resolves issue #88

When the match id below is looked up in is not part of the target functions map. I don't know how many other things are additionally missing but that is the one that I needed to get fixed to make my module functional.

<Match MatchId="urn:oasis:names:tc:xacml:3.0:function:string-starts-with">
    <AttributeValue DataType="http://www.w3.org/2001/XMLSchema#string">whatever</AttributeValue>
    <AttributeDesignator
        AttributeId="urn:oasis:names:tc:xacml:1.0:resource:resource-id"
        Category="urn:oasis:names:tc:xacml:3.0:attribute-category:resource"
        DataType="http://www.w3.org/2001/XMLSchema#string" MustBePresent="true" />
</Match>

Goals

See above.

Approach

I did not try to worry about making this conditional on the use of XACML 3.0 as it was not done for XACML3HigherOrderFunctionCluster.

User stories

See issue #88

Release note

Add the XACML 3.0 comparison functions to the map of functions usable by Match.

Documentation

N/A

It now allows the required functions from the V3.0 specification to be used. Documentation changes would only be required if the current text says it does not work.

Training

N/A

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

N/A

Automation tests

Unit tests

Code coverage information
Integration tests

Details about the test cases and coverage I did not add any unit tests because I was not sure what level of testing you do or do not normally want. The current set of tests do not run on my computer as I am running Windows 10 and do not have an apache server.

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

None.

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested I think just JDK 12.0 but I am not positive what is on my system.

Learning

None - I just used NetBeans.

CLAassistant commented 4 years ago

All committers have signed the CLA.

jimsch commented 4 years ago

The other change is just to make JaveDocs run on my windows system. By default it seems to want to use cp1252 an not UTF-8 and I have not yet figured out how to fix that. If you don't want it then I will remove it.

wso2 / balana