wso2 / balana

Apache License 2.0
122 stars 108 forks source link

Fix flaky test #155

Closed polohan closed 2 years ago

polohan commented 2 years ago

Purpose

Resolve issue #154. ConformanceTestV2.testConformanceTestC's IIC103 case will fail when running in a region that has a different timezone at 2001-01-22T08:23:47-05:00 and at 2002-03-22T08:23:47-05:00.

Goals

Fixing the test so that it won't fail when running in every timezone.

Approach

Without changing the original code, the most simple fix would be modifying the test case. And afaik, no region will switch between DST and standard time between Jun and Aug so simply advancing both dates by 5 months should fix the problem.

User stories

N/A

Release note

N/A

Documentation

N/A

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

N/A. Fixing test.

Marketing

N/A

Automation tests

Security checks

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

OS: Debian GNU/Linux 11 (bullseye) JVM: openjdk version "1.8.0_312" OpenJDK Runtime Environment (build 1.8.0_312-b07) OpenJDK 64-Bit Server VM (build 25.312-b07, mixed mode) (Docker Image: maven:3.8.3-jdk-8)

Learning

Found by running automated tool https://github.com/polohan/No-Time-To-Flake

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

madurangasiriwardena commented 2 years ago

Hi @polohan,

Thank you for your contribution and sorry about the delay in merging it. We are looking forward for more contributions in the future.

Thanks, Maduranga.