search

wso2 / carbon-apimgt

Apache License 2.0
166 stars 625 forks source link

Fix NPE in JWKS endpoint #12261

Closed npamudika closed 6 months ago

npamudika commented 7 months ago

Fixes https://github.com/wso2/api-manager/issues/2454

CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Naduni Pamudika seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (13b6312) 41.76% compared to head (78833d8) 41.98%.

Files Patch % Lines
...ava/org/wso2/carbon/apimgt/impl/utils/APIUtil.java 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12261 +/- ## ============================================ + Coverage 41.76% 41.98% +0.21% - Complexity 3220 3224 +4 ============================================ Files 1824 1824 Lines 134600 134601 +1 Branches 19447 19448 +1 ============================================ + Hits 56220 56514 +294 + Misses 71617 71276 -341 - Partials 6763 6811 +48 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12261/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `35.26% <83.33%> (+0.27%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `20.63% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.