wso2 / carbon-apimgt

Apache License 2.0
166 stars 626 forks source link

Fix the issue of Publishing APIs via Service Catalog with Basic Authentication #12277

Closed Tharanidk closed 8 months ago

Tharanidk commented 8 months ago

When using Service Catalog to push Integration Services from Micro Integrator, although the securityType is set as "BASIC", it is getting changed to "OAuth2" after creating an API. With this PR it will fix this issue.

Resolves: https://github.com/wso2/api-manager/issues/2457

codecov[bot] commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c5e5ef0) 35.38% compared to head (2add832) 42.13%. Report is 8 commits behind head on master.

Files Patch % Lines
...mpl/restapi/publisher/ApisApiServiceImplUtils.java 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12277 +/- ## ============================================ + Coverage 35.38% 42.13% +6.75% - Complexity 2416 3288 +872 ============================================ Files 1831 1831 Lines 134980 135002 +22 Branches 19493 19494 +1 ============================================ + Hits 47764 56886 +9122 + Misses 80891 71287 -9604 - Partials 6325 6829 +504 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12277/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `35.45% <0.00%> (+9.05%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `20.63% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.