search

wso2 / carbon-apimgt

Apache License 2.0
166 stars 626 forks source link

Fixing DCR inconsistency. #12294

Closed prasa7 closed 6 months ago

prasa7 commented 7 months ago

Fix for https://github.com/wso2/api-manager/issues/2033

CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Prasanna Dangalla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 47.48%. Comparing base (a924b94) to head (7075456). Report is 175 commits behind head on master.

Files Patch % Lines
...rest/api/dcr/web/impl/RegistrationServiceImpl.java 54.54% 11 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12294 +/- ## ============================================ + Coverage 42.02% 47.48% +5.45% - Complexity 3232 4139 +907 ============================================ Files 1824 1839 +15 Lines 134605 135684 +1079 Branches 19447 19603 +156 ============================================ + Hits 56567 64427 +7860 + Misses 71241 63691 -7550 - Partials 6797 7566 +769 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12294/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12294/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `42.20% <54.54%> (+6.85%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12294/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `20.56% <0.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.