wso2 / carbon-apimgt

Apache License 2.0
166 stars 626 forks source link

Removed synchronized blocks added when fixing concurrency issues while deploying APIs during high traffic #12308

Closed thisaltennakoon closed 6 months ago

thisaltennakoon commented 7 months ago

Fix https://github.com/wso2/api-manager/issues/2484

In response to the challenges outlined in https://github.com/wso2-enterprise/wso2-apim-internal/issues/3795, an initial approach to synchronise threads between synapse and gateway was implemented via object sharing mechanisms in https://github.com/wso2/carbon-apimgt/pull/12137, https://github.com/wso2/wso2-synapse/pull/2092. However, through further analysis, an alternative method has been discovered to address these issues more efficiently. Consequently, this pull request removes the previously introduced changes, reducing coupling and enhancing the adaptability of the system.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.62%. Comparing base (062820a) to head (2eae438). Report is 35 commits behind head on master.

Files Patch % Lines
...carbon/apimgt/gateway/service/APIGatewayAdmin.java 68.96% 6 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12308 +/- ## ============================================ + Coverage 47.29% 47.62% +0.32% - Complexity 4123 4210 +87 ============================================ Files 1840 1840 Lines 136407 136436 +29 Branches 19734 19745 +11 ============================================ + Hits 64517 64980 +463 + Misses 64281 63818 -463 - Partials 7609 7638 +29 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12308/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12308/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `42.48% <68.96%> (+0.49%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12308/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `20.44% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.