search

wso2 / carbon-apimgt

Apache License 2.0
165 stars 620 forks source link

Fix subsequent registration failures in DCR #12335

Closed RakhithaRR closed 3 months ago

RakhithaRR commented 3 months ago

Fixes https://github.com/wso2/api-manager/issues/2678

Improves the changes done in https://github.com/wso2/carbon-apimgt/pull/12294

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 30.23256% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 47.46%. Comparing base (54d6337) to head (c0faac2). Report is 25 commits behind head on master.

Files Patch % Lines
...rest/api/dcr/web/impl/RegistrationServiceImpl.java 30.23% 25 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12335 +/- ## ============================================= + Coverage 36.82% 47.46% +10.63% - Complexity 0 4175 +4175 ============================================= Files 1840 1840 Lines 136404 136443 +39 Branches 19734 19747 +13 ============================================= + Hits 50231 64757 +14526 + Misses 79651 64046 -15605 - Partials 6522 7640 +1118 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12335/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `42.14% <30.23%> (+13.71%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `20.43% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.