wso2 / carbon-apimgt

Apache License 2.0
165 stars 620 forks source link

Change to java.security.cert.X509Certificate class #12350

Closed shnrndk closed 3 months ago

shnrndk commented 3 months ago

Description

In Java 17, the javax.security.cert package has been removed. To work with X.509 certificates in Java 17 and beyond, we need to use the java.security.cert.X509Certificate class.

Fixes https://github.com/wso2/api-manager/issues/2665

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.64%. Comparing base (df47529) to head (79fa543). Report is 127 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12350 +/- ## ============================================ + Coverage 42.22% 47.64% +5.42% - Complexity 0 4160 +4160 ============================================ Files 1840 1840 Lines 136407 136522 +115 Branches 19734 19765 +31 ============================================ + Hits 57598 65047 +7449 + Misses 71882 63816 -8066 - Partials 6927 7659 +732 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `42.52% <ø> (+6.89%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `20.16% <ø> (-0.28%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.