wso2 / carbon-apimgt

Apache License 2.0
165 stars 620 forks source link

Fix MSSQL specific shared ts reader issue #12379

Closed Lakith-Rambukkanage closed 3 months ago

Lakith-Rambukkanage commented 3 months ago

Fixing : https://github.com/wso2/api-manager/issues/2701

The tsreader (object in the InputStream) gets shared when rs.getBinaryStream is used to retrieve the InputStream. Therefore the subsequent calls should occur after finishing the InputStream reading.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.51%. Comparing base (21910c6) to head (f83009f). Report is 15 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12379 +/- ## ============================================ + Coverage 39.96% 47.51% +7.54% - Complexity 3194 4226 +1032 ============================================ Files 1867 1867 Lines 137935 137935 Branches 19940 19940 ============================================ + Hits 55127 65541 +10414 + Misses 75758 64687 -11071 - Partials 7050 7707 +657 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12379/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `42.45% <100.00%> (+10.09%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/wso2/carbon-apimgt/pull/12379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `20.04% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.