wso2 / carbon-identity-framework

Apache License 2.0
120 stars 542 forks source link

Fix oracle application GET query #6124

Closed aaujayasena closed 2 weeks ago

aaujayasena commented 2 weeks ago

Proposed changes in this pull request

This PR will fix the issue reported, https://github.com/wso2/product-is/issues/21593. Fix with the missing "Comma" at the Get Query.

When should this PR be merged

[Please describe any preconditions that need to be addressed before we can merge this pull request.]

Follow up actions

[List any possible follow-up actions here; for instance, testing data migrations, software that we need to install on staging and production environments.]

-

Checklist (for reviewing)

General

Functionality

Code

Tests

Security

Documentation

CLAassistant commented 2 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

jenkins-is-staging commented 2 weeks ago

PR builder started Link: https://github.com/wso2/product-is/actions/runs/11791954080

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.04%. Comparing base (85e4e76) to head (1c45b4f). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6124 +/- ## ============================================ + Coverage 40.77% 41.04% +0.27% - Complexity 14474 14654 +180 ============================================ Files 1772 1775 +3 Lines 117761 118353 +592 Branches 19116 19203 +87 ============================================ + Hits 48019 48580 +561 - Misses 62451 62474 +23 - Partials 7291 7299 +8 ``` | [Flag](https://app.codecov.io/gh/wso2/carbon-identity-framework/pull/6124/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/wso2/carbon-identity-framework/pull/6124/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `25.47% <ø> (+0.50%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jenkins-is-staging commented 2 weeks ago

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/11791954080 Status: failure

aaujayasena commented 2 weeks ago

PR builder failed test cases are not related to this change. This change is only effecting for the Oracle cases.