search

wso2 / cellery-controller

Apache License 2.0
46 stars 14 forks source link

Support Service Mesh Interface #110

Closed afkham closed 3 years ago

afkham commented 5 years ago

Description: Supporting SMI would allow us to easily support a number of service meshes without being bound to a single SM. We could even allow the user to select a supported SM of choice during installation of Cellery.

Useful links https://smi-spec.io/ https://github.com/deislabs/smi-spec/ https://github.com/deislabs/smi-sdk-go/

LinkerD is working on supporting SMI

There's no Native support for Istio but there's an Istio adapter here https://github.com/deislabs/smi-adapter-istio

There's also maesh, which supports SMI natively. https://blog.containo.us/announcing-maesh-a-lightweight-and-simpler-service-mesh-made-by-the-traefik-team-cb866edc6f29

Mirage20 commented 5 years ago

The smi istio controller doesn't have most of the API's like envoy-filters, gateways which are used in our controller.

Currently, they only have VirtualServices with limited configurations (no tcp support and few http routing rules) https://github.com/deislabs/smi-adapter-istio/blob/master/pkg/apis/networking/v1alpha3/virtualservice_types.go

and this is our current virtual service used for routing https://github.com/wso2-cellery/mesh-controller/blob/master/pkg/apis/istio/networking/v1alpha3/virtual_service_types.go

afkham commented 5 years ago

The smi istio controller doesn't have most of the API's like envoy-filters, gateways which are used in our controller.

Currently, they only have VirtualServices with limited configurations (no tcp support and few http routing rules) https://github.com/deislabs/smi-adapter-istio/blob/master/pkg/apis/networking/v1alpha3/virtualservice_types.go

and this is our current virtual service used for routing https://github.com/wso2-cellery/mesh-controller/blob/master/pkg/apis/istio/networking/v1alpha3/virtual_service_types.go

Yes that may be true today because the spec is at an early stage, but at some point we should consider moving to SMI when the spec is ready. We could also raise these concerns on https://github.com/deislabs/smi-spec/ so that they could consider incorporating it.

uthaiyashankar commented 3 years ago

Won't fix. Cellery project is not actively maintained.