wso2 / cellery-controller

Apache License 2.0
46 stars 14 forks source link

Update Web Cell Gateway Arguments to support Observability #55

Closed nadundesilva closed 5 years ago

nadundesilva commented 5 years ago

Purpose

Previously the provided arguments were pointing to Istio mixer for reporting Observability data. This needs to be altered for Cellery Observability to work.

Goals

Allow the user to view Web Cell tracing and other data.

Approach

The argument for specifying the zipkinAddress was changed to point to the SP Worker. The serviceCluster was also updated to be consistent with the other pods.

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

Security checks

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

codecov-io commented 5 years ago

Codecov Report

Merging #55 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   62.62%   62.62%           
=======================================
  Files          26       26           
  Lines        1295     1295           
=======================================
  Hits          811      811           
  Misses        470      470           
  Partials       14       14
Impacted Files Coverage Δ
pkg/controller/gateway/resources/deployment.go 77.04% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c407148...86a55da. Read the comment docs.