Check if debug is enabled - Githubissues

wso2 / charon

123 stars 165 forks source link

Check if debug is enabled #374

Closed AyoobAboosalih closed 2 years ago

AyoobAboosalih commented 2 years ago

Purpose

To check if debug has been enabled

Goals

To prevent DEBUG logs from being logged if the usr hasn't enabled debugging

Approach

A conditional checker was wrapped around all instances where debug logs are present

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Related PRs

https://github.com/wso2/charon/pull/373

AyoobAboosalih commented 2 years ago

@ShanChathusanda93 Please review this

jenkins-is-staging commented 2 years ago

PR builder started Link: https://github.com/wso2/product-is/actions/runs/2703093566

jenkins-is-staging commented 2 years ago

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/2703093566 Status: failure

jenkins-is-staging commented 2 years ago

PR builder started Link: https://github.com/wso2/product-is/actions/runs/2711583085

jenkins-is-staging commented 2 years ago

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/2711583085 Status: success