wso2 / docs-apim

Apache License 2.0
70 stars 393 forks source link

Error in message formatter config #7556

Closed vikumkbv closed 9 months ago

vikumkbv commented 9 months ago

Hi Team,

In the documentation [1], we found a typo in the [[custom_message_formatters]] class, please correct is as follows.

Current version

[[custom_message_formatters]]
class = "org.wso2.carbon.relay.BinaryRelayBuilder"
content_type = "application/json/badgerfish"

[[custom_message_builders]]
class = "org.wso2.carbon.relay.BinaryRelayBuilder"
content_type = "application/json/badgerfish"

Corrected version

[[custom_message_formatters]]
class = "org.wso2.carbon.relay.ExpandingMessageFormatter"
content_type = "application/json/badgerfish"

[[custom_message_builders]]
class = "org.wso2.carbon.relay.BinaryRelayBuilder"
content_type = "application/json/badgerfish"

[1] https://apim.docs.wso2.com/en/latest/install-and-setup/setup/mi-setup/message_builders_formatters/message-builders-and-formatters/#handling-message-relay

Thanks, Vikum

Mariangela commented 9 months ago

Assignees @Mariangela

Status In progress

@DinithiDiaz , I have fixed this issue in [1]. Please review and merge the PR.

@vikumkbv , I see this same mistake in APIM 4.1.0 and 4.0.0 as well. Is the fix that you mentioned applicable to APIM 4.1.0 and 4.0.0 as well?

[1] https://github.com/wso2/docs-apim/pull/7558

DinithiDiaz commented 9 months ago

@DinithiDiaz , I have fixed this issue in [1]. Please review and merge the PR.

Hi @Mariangela, merged the PR.

DinithiDiaz commented 9 months ago

Sent fixes via https://github.com/wso2/docs-mi/pull/69 and https://github.com/wso2/docs-mi/pull/70 to update the MI 4.2.0 documentation.

Mariangela commented 9 months ago

@DinithiDiaz , I am assuming that this fix is valid for 4.1.0 and 4.0.0 as well. Therefore, I made these changes in the master, 4.1.0 and 4.0.0 branches.