wso2 / docs-open-banking

Apache License 2.0
39 stars 25 forks source link

Confirmation of Funds Service Flow v1.3.6 #236

Closed hasoxy closed 3 years ago

hasoxy commented 3 years ago

In the above mentioned docs some of the steps and the versions compatible are not clear.

Suggested Labels:

Suggested Assignees: @SSParamee Affected Product Version:

OS, DB, other environment details and versions:
mysql 5.7 / 5.8

Related Issues:

code_verifier | This is the code we used to generate the code challenge in the POST /consents/{consentId}/authorisations API call.

The url https://:/xs2a/v1/funds-confirmations \ should change to https://:8243/xs2a/v1/funds-confirmations .

isharailanga commented 3 years ago

Hi @hasoxy and @SSParamee,

The mysql version is known as 5.7 and above but the OBIAM db configuration script gives errors in the mysql 5.8 version which has to be fixed manually.

Please note that this won't be an issue since we don't recommend to run configuration scripts for a production environment. So adding a note to Try Local Setup or updating internal dev-docs will help with this.

SSParamee commented 3 years ago

Hi @isharailanga and @hasoxy,

We have instructed to run the OBIAM db configuration script only in the Try Local Setup doc and in that doc, we have mentioned the versions for the db types. Hence we don't need this to be addressed.

hasoxy commented 3 years ago

Hi @isharailanga and @SSParamee, I did check the two docs I understood you both are correct, please avoid the database version concern.

isharailanga commented 3 years ago

The mysql version is known as 5.7 and above but the OBIAM db configuration script gives errors in the mysql 5.8 version which has to be fixed manually.

The supported MySQL version is 5.7 only. This was corrected in https://docs.wso2.com/display/OB200/Prerequisites.

the use of a PKCE can be seen. It is better if that can be made more clearer.

The OAuth PKCE spec is referenced here. Please let me know if further explanation is required at this level. Anything specific.

Please clarify point no2 & no3.

hasoxy commented 3 years ago

Please find the values used by me when trying out the flow manuallly. code_challenge_method = S256 codechallenge = qjrzSW9gMiUgpUvqgEPE4-8swvyCtfOVvg55o5S_es code_verifier = M25iVXpKU3puUjFaYWg3T1NDTDQtcW1ROUY5YXlwalNoc0hhakxifmZHag.

Points 2 and 3 were clarified off line please feel free to ask me if there is anything else.

isharailanga commented 3 years ago

Hi @hasoxy,

Thanks for sharing the values. Closing the issue as the doc is updated as follows:

Task 1 The supported MySQL version is 5.7 only. This was corrected in https://docs.wso2.com/display/OB200/Prerequisites.

Task 2, 3 & 4 Updated the Try Out Confirmation of Funds Service Flow v1.3.6 doc as follows: image

Task 5 Fixed the sample request: image