search

wso2 / financial-open-banking

WSO2 Open Banking Accelerator is a collection of technologies that increases the speed and reduces the complexity of adopting open banking compliance. Instead of building a solution from scratch, you can use WSO2 Open Banking Accelerator to meet all legislative requirements with additional benefits beyond compliance.
Apache License 2.0
7 stars 21 forks source link

Fixing issue in event subscription error handling #3

Closed Ashi1993 closed 10 months ago

Ashi1993 commented 10 months ago

Fixing issue in event subscription error handling

This PR contains the modification done in event subscription handling to set custom status and error response formats from tooklit level.

Issue link: https://github.com/wso2-enterprise/financial-open-banking/issues/8320

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. [x] Built complete solution with pull request in place.
  2. [x] Ran checkstyle plugin with pull request in place.
  3. [x] Ran Findbugs plugin with pull request in place.
  4. [ ] Ran FindSecurityBugs plugin and verified report.
  5. [x] Formatted code according to WSO2 code style.
  6. [x] Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. [ ] Migration scripts written (if applicable).
  8. [ ] Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. [x] Written unit tests.
  2. [ ] Documented test scenarios(link available in guides).
  3. [ ] Written automation tests (link available in guides).
  4. [ ] Verified tests in multiple database environments (if applicable).
  5. [ ] Verified tests in multiple deployed specifications (if applicable).
  6. [ ] Tested with OBBI enabled (if applicable).
  7. [ ] Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

AmilaSamith commented 10 months ago

Hi @Ashi1993,

IMO its nice to have a "-" between parameter names and their description in method comments as below. Just a suggestion form my side. WDYT?

    /**
     * This method is used to create event subscriptions.
     *
     * @param eventSubscriptionRequestDto - Event Subscription DTO
     * @return EventSubscriptionResponse - Event Subscription Response
     */

Thanks Amila

Ashi1993 commented 10 months ago

Hi @Ashi1993,

IMO its nice to have a "-" between parameter names and their description in method comments as below. Just a suggestion form my side. WDYT?

    /**
     * This method is used to create event subscriptions.
     *
     * @param eventSubscriptionRequestDto - Event Subscription DTO
     * @return EventSubscriptionResponse - Event Subscription Response
     */

Thanks Amila

Normally we add a few spaces between the name and the description. Shall We stick to that? I will adjust my code according to that

AmilaSamith commented 10 months ago

Hi @Ashi1993, IMO its nice to have a "-" between parameter names and their description in method comments as below. Just a suggestion form my side. WDYT?

    /**
     * This method is used to create event subscriptions.
     *
     * @param eventSubscriptionRequestDto - Event Subscription DTO
     * @return EventSubscriptionResponse - Event Subscription Response
     */

Thanks Amila

Normally we add a few spaces between the name and the description. Shall We stick to that? I will adjust my code according to that

Noted and if that's the case let's stick to that approach going forward. I highlighted that because I saw different styles in different classes and methods.