wso2 / financial-services-accelerator

WSO2 Open Banking Accelerator is a collection of technologies that increases the speed and reduces the complexity of adopting open banking compliance. Instead of building a solution from scratch, you can use WSO2 Open Banking Accelerator to meet all legislative requirements with additional benefits beyond compliance.
Apache License 2.0
7 stars 22 forks source link

Modified DCR implementation to make SSA an optional parameter #62

Closed VenukshiMendis closed 5 months ago

VenukshiMendis commented 5 months ago

Modified DCR implementation to make SSA an optional parameter

This PR modifies the existing DCR implementation to make Software Statements Assertion an optional parameter when creating and updating application registrations. Also, this enhances the existing DCR implementation to add all request metadata including toolkit-specific ones, as SP properties of the relevant Service Provider Application.

Issue link: https://github.com/wso2/financial-open-banking/issues/61

Doc Issue: https://docs.google.com/document/d/1A6rVJz43DyO634b4LodPuFsacbJLqV30EK1xsemyJPE/edit?usp=sharing

Applicable Labels: OB Accelerator


Development Checklist

  1. [x] Build complete solution with pull request in place.
  2. [x] Ran checkstyle plugin with pull request in place.
  3. [ ] Ran Findbugs plugin with pull request in place.
  4. [ ] Ran FindSecurityBugs plugin and verified report.
  5. [x] Formatted code according to WSO2 code style.
  6. [ ] Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. [ ] Migration scripts written (if applicable).
  8. [ ] Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. [ ] Written unit tests.
  2. [ ] Verified tests in multiple database environments (if applicable).
  3. [ ] Tested with BI enabled (if applicable).
CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.