Fix localize Or and Username labels in Authentication Portal and Recovery Portal - Githubissues

wso2 / identity-apps

Apache License 2.0

69 stars 259 forks source link

Fix localize Or and Username labels in Authentication Portal and Recovery Portal #6826

Closed HasiniSama closed 2 months ago

HasiniSama commented 2 months ago

Purpose

Fixes https://github.com/wso2/product-is/issues/20936

The i18nKey variable is set to "Username" instead of "username". The username string does not get translated correctly due to this.
The string "or" is defined directly without resolving it according to the specific locale. Both of these needs to be fixed.

Screenshot 2024-09-09 at 17 54 59

Checklist

[ ] e2e cypress tests locally verified. (for internal contributers)
[x] Manual test round performed and verified.
[ ] UX/UI review done on the final implementation.
[ ] Documentation provided. (Add links if there are any)
[ ] Relevant backend changes deployed and verified
[ ] Unit tests provided. (Add links if there are any)
[ ] Integration tests provided. (Add links if there are any)

Security checks

[x] Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines
[ ] Ran FindSecurityBugs plugin and verified report
[x] Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets

wso2-jenkins-bot commented 2 months ago

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.