wso2 / identity-apps

Apache License 2.0
69 stars 259 forks source link

Ingore regex pattern matching for inbound OAuth apps #7123

Open sahandilshan opened 1 day ago

sahandilshan commented 1 day ago

Purpose

$subject To properly fix this, we have initially tried to do the regex pattern validation asynchronously with a webworker and kill the asyc task within a one second period if the regex pattern validation didn't complete. This is the best approach to do this. But when we try that we came up with several blockers where we couldn't use the async function inside the url-input component due to the way it was written. So we couldn't go with the above approach we mentioned. Therefore as a fix to this we are going to just ignore the regex pattern validation for inbound-oauth apps. Create this https://github.com/wso2/product-is/issues/21706 issue here to support the async validation for URLInput component.

Related Issues

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.80%. Comparing base (cdd3bfb) to head (0aca53b). Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/src/utils/url-utils.ts 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7123 +/- ## ========================================== - Coverage 32.02% 31.80% -0.23% ========================================== Files 41 41 Lines 893 893 Branches 220 216 -4 ========================================== - Hits 286 284 -2 - Misses 557 559 +2 Partials 50 50 ``` | [Flag](https://app.codecov.io/gh/wso2/identity-apps/pull/7123/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [@wso2is/core](https://app.codecov.io/gh/wso2/identity-apps/pull/7123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | `31.80% <75.00%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/wso2/identity-apps/pull/7123?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2) | Coverage Δ | | |---|---|---| | [modules/core/src/utils/url-utils.ts](https://app.codecov.io/gh/wso2/identity-apps/pull/7123?src=pr&el=tree&filepath=modules%2Fcore%2Fsrc%2Futils%2Furl-utils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wso2#diff-bW9kdWxlcy9jb3JlL3NyYy91dGlscy91cmwtdXRpbHMudHM=) | `23.40% <75.00%> (-4.26%)` | :arrow_down: |
wso2-jenkins-bot commented 17 hours ago

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.