Open sahandilshan opened 1 day ago
Attention: Patch coverage is 75.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 31.80%. Comparing base (
cdd3bfb
) to head (0aca53b
). Report is 35 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
modules/core/src/utils/url-utils.ts | 75.00% | 2 Missing :warning: |
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Purpose
$subject To properly fix this, we have initially tried to do the regex pattern validation asynchronously with a webworker and kill the asyc task within a one second period if the regex pattern validation didn't complete. This is the best approach to do this. But when we try that we came up with several blockers where we couldn't use the async function inside the
url-input
component due to the way it was written. So we couldn't go with the above approach we mentioned. Therefore as a fix to this we are going to just ignore the regex pattern validation for inbound-oauth apps. Create this https://github.com/wso2/product-is/issues/21706 issue here to support the async validation for URLInput component.Related Issues