search

wso2 / k8s-api-operator

API Operator for Kubernetes
Apache License 2.0
115 stars 48 forks source link

Update MI container lifecycle to handle graceful shutdown #578

Closed abeykoon closed 3 years ago

abeykoon commented 3 years ago

Purpose

Add a preStop handler to MI container lifecycle so that stop.sh script is called upon any container termination. Related documentation at K8s [1].

Fixes: https://github.com/wso2/k8s-api-operator/issues/577

[1]. https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Hasitha Abeykoon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-io commented 3 years ago

Codecov Report

Merging #578 (b14dd49) into master (4da41af) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   35.09%   35.09%           
=======================================
  Files          15       15           
  Lines         758      758           
=======================================
  Hits          266      266           
  Misses        437      437           
  Partials       55       55
Flag Coverage Δ
unit_tests 35.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4da41af...b14dd49. Read the comment docs.