wso2 / kubernetes-apim

Kubernetes and Helm resources for WSO2 API Manager
Apache License 2.0
112 stars 216 forks source link

Required indentation in externally configured deployment toml #544

Open renuka-fernando opened 2 years ago

renuka-fernando commented 2 years ago

Description: Two spaces in https://github.com/wso2/kubernetes-apim/blob/3cb0e1cce300dd3ce6e5530a8270b33b237bf796/simple/am-single/templates/am/instance/wso2am-single-node-am-conf.yaml#L24 should be removed

Otherwise the deployment toml file which is provided as external file should be in the following format.

First line without spaces, rest lines with two spaces

[server]
  hostname = "{{ .Values.wso2.deployment.am.ingress.management.hostname }}"
  #offset=0
  base_path = "${carbon.protocol}://${carbon.host}:${carbon.management.port}"

Suggested Labels:

Suggested Assignees:

Affected Product Version:

OS, DB, other environment details and versions:

Steps to reproduce:

Related Issues:

renuka-fernando commented 2 years ago

This commit may fix the issue https://github.com/wso2/kubernetes-apim/commit/8fa1eb5ffee4554ec3bbfdfbc217a5fd9d677426 which is done to 4.1.0