search

wso2 / kubernetes-apim

Kubernetes and Helm resources for WSO2 API Manager
Apache License 2.0
114 stars 216 forks source link

WSO2 APIM pod takes a fixed time to be ready due to `initialDelaySeconds` #608

Open matoruru opened 9 months ago

matoruru commented 9 months ago

Description: I realized that WSO2 pod is taking some fixed time like 3 mins to be ready. And the reason could be readinessProbe.initialDelaySeconds. Can't we have WSO2 Kubernetes manifest have startupProbe instead?

The reason why I suggest this is that, startupProbe should give this problem dynamic and flexible time to be ready just depends on the machine spec and the time that some WSO2 processes actually take.

Reference: playground-prove-initialdelayseconds-is-bad-startupprobe-is-better

Suggested Labels: Suggestion, Improvement

Suggested Assignees: @matoruru

Affected Product Version: Not sure

OS, DB, other environment details and versions:

Steps to reproduce: Restart the Deployment resource of APIM.

Related Issues:

matoruru commented 9 months ago

There are livenessProbe and readinessProbe but no startupProbe.

matoruru commented 9 months ago

We, user, could extend this manifest by forking but I think it worth to have in this official-provided manifest.

matoruru commented 9 months ago

If I got assigned to this issue I would be happy to work on this.

matoruru commented 9 months ago

For notification please forgive me to tag you two as most contributors in this repo @chirangaalwis @prasa7