search

wso2 / kubernetes-is

Kubernetes and Helm resources for WSO2 Identity Server
Apache License 2.0
65 stars 114 forks source link

Align name of MySQL dependency condition key #310

Closed codebling closed 2 years ago

codebling commented 3 years ago

Purpose

Resolves a triple mismatch for the key name of the MySQL deployment setting. Documentation, values.yaml and requirements.yaml all had different settings. These were, respectively, wso2.deployment.dependencies.mysql.enabled, wso2.deployment.dependencies.mysql, and wso2.mysql.enabled.

This PR aligns all of these to use the key from the documentation, namely wso2.deployment.dependencies.mysql.enabled. This is the form preferred by Helm for conditions.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

ThilinaManamgoda commented 2 years ago

@codebling Could you please sign our Contributor License Agreement

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

codebling commented 2 years ago

@ThilinaManamgoda thanks for reviewing and approving. I've signed the CLA. (Though I'm not sure I understand what would have happened in this particular case had I NOT signed...Is this one-line bug fix my intellectual property? Would not signing mean WSO2 can never fix the bug?)