wso2 / kubernetes-is

Kubernetes and Helm resources for WSO2 Identity Server
Apache License 2.0
65 stars 115 forks source link

Fix indentation in wso2is-pattern-1-identity-server-conf.yaml #321

Open RichardSufliarsky opened 2 years ago

RichardSufliarsky commented 2 years ago

Helm chart for is-pattern-1 doesn't work if you try to include deployment.toml configuration in values.yaml file.

Steps to reproduce: Add this section under wso2.deployment.wso2is in values.yaml:

      config:
        deployment.toml: |-
          [server]

Proposed solution: Indentation in: https://github.com/wso2/kubernetes-is/blob/9c5af98b8946fbc5104333dbb55fbaa24376f4ef/advanced/is-pattern-1/templates/is/wso2is-pattern-1-identity-server-conf.yaml#L25 should be as here: https://github.com/wso2/kubernetes-apim/blob/65209e22670756215ef9809e1372dc3aeaa1a4af/advanced/am-pattern-4/templates/am/control-plane/instance-1/wso2am-pattern-4-am-control-plane-conf.yaml#L24

Instead of this:

data:
  {{- range $index, $content := .Values.wso2.deployment.wso2is.config }}
  {{ $index }}: |-
  {{ tpl $content $ | indent 4 }}
  {{- end }}

Should be this:

data:
  {{- range $index, $content := .Values.wso2.deployment.am.cp.config }}
  {{ $index }}: |-
{{ tpl $content $ | indent 4 }}
  {{- end }}