wso2 / product-iots

Welcome to the WSO2 IoT Server source code! For info on working with the WSO2 IoT Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
184 stars 181 forks source link

Jaggery app conf files should pick host name and port configurations from a central place #1290

Open madawas opened 7 years ago

madawas commented 7 years ago

Ideally, jaggery app configs should pick the hostname and ports should pick from the variables which are in iot-server.sh

dilee commented 7 years ago

I would like to suggest that we pick the super admin password from a central place as well.

harshanL commented 7 years ago

This has been already fixed. All the jaggery config files are referring to hostnames defined in iot-server.sh script. So once it's updated there it will be picked automatically by jaggery apps.

madawas commented 7 years ago

@harshanL does this mean that we can remove https://github.com/wso2/product-iots/blob/master/modules/scripts/change-ip.sh#L60-L73 https://github.com/wso2/product-iots/blob/master/modules/scripts/change-ip.sh#L159-L165 https://github.com/wso2/product-iots/blob/master/modules/scripts/change-ip.sh#L205-L208

from change-ip.sh script?

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity.