[Development] Bind `templateId` to Application Listing Component

brionmario commented 3 years ago

Feature/Improvement

Add templateId to Application Listing Component

Description

Currently, Application REST APIs listing endpoint don't provide the templateId. **** (Now the BE implementation is completed with https://github.com/wso2/product-is/issues/10681#issuecomment-1169497984). In Console, we are displaying the template name on the application edit page as follows.

And we are not showing the template in the listing which gives bad UX.

Describe the solution you propose

Improve the Application listing endpoint to include templateId in the response and add a label to the application listing item to display the templateId and later on implement to filter applications based on that criteria.

Design

https://github.com/wso2/product-is/issues/14114

Effort and Timeline

Effort Type	Estimation - Budgeted	Estimation - Definitive	Actual Time
BE	10	10	XX
FE	10	10	XX
SRE	0	0	0
QA	2	2	XX
DoC	0	0	XX
Total	22	22	XX

Expected date in prod: 27-07-2022 Delivered date in prod: DD-MM-YYYY

Delivery

Task breakdown

Phase 1

MVP 1:

[x] Design - https://github.com/wso2/product-is/issues/14114 (In-Progress)

MVP 2:

[x] Backend Implementation
- The backend is being fixed with the following by @VivekVinushanth
  
  https://github.com/wso2/product-is/issues/10681#issuecomment-1169497984

MVP 3:

[x] Displaying templateId in application listing item
- [x] Update the frontend API service layer.
- [x] Update application listing table item.
- [x] Implement necessary styles to show the templateId tag.

MVP 4:

[ ] Consume templateId for filtering
- [ ] Add the templateId to advanced search criteria.

Delivery plan

N/A

Check Items

[x] Design reviews
[x] Development Preview
[ ] Implementation Demo

mefarazath commented 3 years ago

With the current schema, we have few limitations in supporting this without introducing perf hits.

In the current schema, application basic information is maintained in the table 'SP_APP', while the templateID is stored in the 'SP_METADATA' table.

Application Listing works on the SP_APP table. If we are to support sending templateID as an attribute in the application list response, then

Fetch the templateID from SP_METADATA for each listed application before building the list response
Modify the list application query to join SP_APP and SP_METADATA table
Make templateID a dedicated column in SP_APP

Approach 1 has a perf impact with additional DB query added to each application listed in the list response
Approach 2 will make the DAO logic complex and also have a perf impact when the number of apps in large
Approach 3 - In terms of performance and complexity this is the best option. However, this will introduce a schema change and a possible migration requirement.

yasinmiran commented 2 years ago

[ ] Do a competitor analysis.
[ ] Come up with design variants.
[ ] Functionality - Template filtering.

yasinmiran commented 2 years ago

Implementation PRs did by @VivekVinushanth

Mapping related issue

yasinmiran commented 2 years ago

@malshan1998 please cherry-pick take the changelist of https://github.com/wso2/identity-apps/pull/3091 locally and test these changes work without any issue.