wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
748 stars 729 forks source link

[SCIM2] Unexpected status code when patching a non existing group #11248

Closed AnjanaSamindraPerera closed 2 weeks ago

AnjanaSamindraPerera commented 3 years ago

Describe the issue: Patching a group with non existing group gives status code 500. Screenshot from 2021-02-11 14-36-17

How to reproduce: Sent a PATCH request to https://localhost:9443/scim2/Groups/{id} with a non existing group id with the following request body.


{
  "schemas": [
    "urn:ietf:params:scim:api:messages:2.0:PatchOp"
  ],
  "Operations": [  
     {
      "op": "add",
      "value": {
        "members": [
          {
            "display": "samindra",
            "value":"17712b98-3957-48cd-bc49-c4559df817b3"
          }
        ]
      }
    }
  ]
}

Expected behavior: For a non existing resource status code 404 should be given with the response.

Environment information (Please complete the following information; remove any unnecessary fields) :

isharak commented 2 weeks ago

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!