search

wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
746 stars 724 forks source link

Return userID along with the response in validateCode api and setPassword api #11519

Open Chathurangap688 opened 3 years ago

Chathurangap688 commented 3 years ago

Is your suggestion related to an experience ? Please describe.

In current IS versions return user object when user set password by /setPassword api and also account confirmation by /validateCode api. In these cases user object not return userID. Describe the improvement

So, It's better to return userId along with the response in above apis.

nilasini commented 2 years ago

@Chathurangap688 Isn't this issue reproducible in master?

Chathurangap688 commented 2 years ago

@Chathurangap688 Isn't this issue reproducible in master?

It is reproducible in master

nilasini commented 2 years ago

Did we fix do the fix for master?

Chathurangap688 commented 2 years ago

Did we fix do the fix for master?

This issue has been resolved by another issue. It is returning not only userId but also user object. Issue: https://github.com/wso2/product-is/issues/10603 Related PR: https://github.com/wso2-extensions/identity-governance/pull/463

nilasini commented 2 years ago

@Chathurangap688 but seems the user object returned through the PR [1] doesn't have user id. Could you please confirm whether [1] fixes the issue mentioned in the description?

[1] https://github.com/wso2-extensions/identity-governance/pull/463