wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
741 stars 720 forks source link

[TypingDNA Integration] MFA options set by adaptive authentication script are skipped and no errors are thrown if TypingDNA is not setup correctly #13223

Open deshalw opened 2 years ago

deshalw commented 2 years ago

Describe the issue: $RCS below

How to reproduce:

  1. Setup MFA in an SP and add an adaptive script to use TypingDNA to conditionally enable 2nd step verification

    tested with basic auth for 1st step and TOTP for 2nd step

  2. Disable TypingDNA from the IdP

    eg. go to Identity Providers -> Resident -> Other settings -> TypingDNA Configuration and uncheck Enable TypingDNA

  3. Try logging in to the SP with different credential input patterns

  4. Verify how the validations work by analysing the log entries

Actual behavior:

Expected behavior:

Environment information (Please complete the following information; remove any unnecessary fields) :


Optional Fields

Related issues:

Suggested labels:

nilasini commented 2 years ago

@deshalw could you please explain more on the first step and second step authenticators seems the description is confusing. Once place it is mentioned as "TypingDNA to check the 2nd step" and in other place it is mentioned as "the second-factor (TOTP) was never prompted".

deshalw commented 2 years ago

@nilasini - Updated the issue description to make the steps more clear. Please do let me know if any further info is required.