search

wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
735 stars 714 forks source link

Fields Required for Input in SMS Provider Page Not Clearly Indicated as Mandatory in UI #17494

Closed NilukaSripalim closed 6 months ago

NilukaSripalim commented 9 months ago

Describe the issue: On the SMS Provider Page, there are fields that require user input (sms provider configurations), but they are not clearly marked as mandatory in the UI. Users are not aware that these fields are required, leading to confusion and incomplete form submissions.

How to reproduce: Navigate to the SMS Provider (Branding > Page in the application. Observe the fields that require user input. Notice that there are no visible indicators or labels denoting these fields as mandatory.

Expected behavior: Mandatory fields on the SMS Provider Page should be visibly indicated in the UI, either through asterisks (*) next to the field labels or any other universally recognized symbol.

Environment information (Please complete the following information; remove any unnecessary fields) :

Screenshot 2023-11-01 at 12 18 37 Screenshot 2023-11-01 at 12 17 37 Screenshot 2023-11-01 at 12 17 37
dasuni-30 commented 8 months ago

The required prop is not passed to the text field of FinalFormField. Hence the required fields are not displayed as required even if we make them required. This PR fixes the issue. https://github.com/wso2/identity-apps/pull/4614

The required (*) is not displayed in red color in the text field. Hence this needs to be fixed from the oxygen-ui.

Screenshot 2023-11-15 at 14 44 48
brionmario commented 6 months ago

Making the asterisks red will be covered in https://github.com/wso2/product-is/issues/18642