search

wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
728 stars 713 forks source link

[SMS OTP Provider] UI gives the perspective of able to configure more than 1 custom sms otp provider #17812

Open GoushiRam opened 7 months ago

GoushiRam commented 7 months ago

Describe the issue: There are few issues in "SMS OTP Provider" that give the experience that the user is capable of adding more than 1 SMS OTP Providers

  1. The UI provides the tab navigation which seems that we provide multiple SMS OTP configurations
image
  1. The Delete section is separate from the SMS OTP Configuration components. Further the deletion context is in plural providing the effect that multiple SMS OTP configurations can be configured and deleted.
image

How to reproduce:

  1. Login to IS Console
  2. Navigate to Branding > Channels and navigate within SMS OTP Configurations

Expected behavior: The SMS OTP behaviour should provide the experience only one type of configuration is allowed at a given time.

Environment information (Please complete the following information; remove any unnecessary fields) :

Optional Fields

Related issues:

Suggested labels:

brionmario commented 7 months ago

If the button groups are not intuitive enough, we can implement a radio card component and see if that sticks. Anyway, we shouldn't go with the traditional radio groups since the logos of Twillio and Vonage will be onboarded later.

Screenshot 2023-11-19 at 10 44 44

https://mui.com/joy-ui/react-radio-button/#position