Closed Lakshan-Banneheke closed 10 months ago
Based on my initial look, There are some features added to hypr jsp file in identity apps such as
We can migrate these changes to connector but we have to test it.
But there is another improvement where the user name is validated against Email regex format, which means email type Username as inly allowed and we can't migrate this behaviour to connector.
Hence coping entire jsp in identity apps to connector is not possible we have to check case by case.
Adding to what @Thumimku mentioned, I don't think we can directly remove the jsp from identity-apps as well after migrating the changes to the hypr connector.
New connector publication requested via mail: :"Request to Host a New Version of HYPR Authenticator"
TODO: Update docs after publishing new connector
Describe the issue: The hyprlogin.jsp is available in both the identity-apps[1] and identity-outbound-auth-hypr[2] connector.
According to the documentation[3], when configuring the hypr login with the Identity Server, the user is supposed to get the hyprlogin.jsp file from the dentity-outbound-auth-hypr[2] connector and paste it into the authentication endpoint.
However, the hyprlogin.jsp file in the dentity-outbound-auth-hypr connector has not been updated for 2 years. The jsp in the identity-apps has been updated and contains different functionality to the jsp in the connector.
Had a discussion with @brionmario regarding this and it seems like the hyprlogin.jsp should not exist in the identity-apps repo and is currently present due to the unification.
Therefore, need to look into:
It is critical to update the hyprlogin.jsp in the connector repo as customers who use the documentation to set up hypr will be obtaining the file from the connector
[1] https://github.com/wso2/identity-apps/blob/master/identity-apps-core/apps/authentication-portal/src/main/webapp/hyprlogin.jsp [2] https://github.com/wso2-extensions/identity-outbound-auth-hypr/blob/main/components/org.wso2.carbon.identity.application.authenticator.hypr/src/main/resources/artifacts/hyprlogin.jsp [3] https://is.docs.wso2.com/en/next/guides/authentication/passwordless-login/add-passwordless-login-with-hypr/#deploy-the-hypr-login-page