Open Achintha444 opened 9 months ago
Here we are checking some attributes before loading the data for that application.
The reason is
Retrieving the secret involves additional db call
Above db call happen every time an application is retrieved.
To achieve above optimisation without compromising the performance, we can relax the check by checking only android package existence for the application like below.
if (StringUtils.isNotEmpty(clientAttestationMetaData.getAndroidPackageName())) {
clientAttestationMetaData.setAndroidAttestationServiceCredentials
(getAndroidAttestationServiceCredentials(serviceProvider));
}
PR: https://github.com/wso2/carbon-identity-framework/pull/5526
Other than the above backend improvements, the following can also be done as an improvement on the frontend side:
Describe the improvement When disabling the client attestation from api auth attestation configurations should not be removed. Once it's enabled back it should be possible to proceed without re-adding configs.
Same with enabling or disabling app native api authentication